Ory is the largest open source community in the world for cloud software application security. We maintain advanced open source security software solving authentication, authorization, access control, application network security, and delegation. Ory implements a variety of industry and best-practice standards including OAuth 2.0 / OAuth 2.1, OpenID Connect, Zero Trust Networking, Google Zanzibar Policy Framework, FIDO2 U2F, WebAuthn, TOTP, and more.

Ory Community

<@U010F2N7G2X> <@U011D3UQKNY>
Finally updated our PR: <https://github.com/ory/oathkeeper/pull/916>

Seems like most was already implemented through others, but it's still adding a few test cases. Yay, or nay?

Thanks for updating the PR!
IMO this would be a good addition, but lets wait for Aeneas reply on gh!

(might take a few days depending on what else is going on)

I see it got approved, is there anything else I need to do now? :smile:

<https://github.com/ory/oathkeeper/pull/916>

it looks like the grpc middleware tests are failing

That’s not a time out: <https://github.com/ory/oathkeeper/actions/runs/4216722348/jobs/7348060071#step:9:172>

It looks like you might run into a case where the tests use an empty subject. Since the code was changed, it’s possible that they now fail :)

any hint where to provide the subject line?

never used grpc before, i am a bit out of my depth :smiley:

not really :disappointed: I’d probably look at the failing test and revere engineer from there

but I think "now" there is another failure :smile:

i think that's the original bug we reported with accept encoding being forwarded to the session store

not really sure where to put it, so basically the problem is:

• there's a config for forwarding to the session store
• that config includes ForwardHTTPHeaders (which is a slice)
• i think I need to strip `Accept-Encoding` from that list


but iterating over the slice seems kinda "icky"... as in, probably a performance penalty?

<https://github.com/ory/oathkeeper/blob/master/pipeline/authn/authenticator_bearer_token.go#L105-L122>

i think I would also need to refix this for "cookie"