Hey, I'm coming back to you regarding our PR about...
# contributors
f
Hey, I'm coming back to you regarding our PR about the SAML federation (#2653). Your reviews have been taken into account, and we have finished the tests covering our continuity manager based on RelayState (essential to the SAML flow, more information here #2486). Could you please take a look at it and tell us what's missing on your side for the merge please? Additional note: we are currently writing our SAML vulnerability assessment tests to prove that our implementation covers them all. Merry Christmas everyone, and happy new year! :)
🙌 2
s
Hello @swift-chef-97535 & @high-optician-2097! Happy new year to all the Ory team! Can we have a little part ou your time to get a review of the SAML integration please?
s
@steep-scientist-70493 I am happy to take a look at this. What is the latest status? I dont see an open PR in Hydra
Maybe this one? feat: saml federation #2653 in ory/kratos
👍 1
s
Yes, it's the #2653 in Kratos
s
@steep-scientist-70493 That is a long PR! It looks like a ton of work. Thank you and the team for creating this feature. It looks like there are still some unresolved tests. Do you want to set up time Wednesday afternoon to walk through it?
f
Thank you @swift-chef-97535! Yes we'd be happy to 🙂 Wednesday is a bit tricky for us, would Thursday be good for you? 4pm?
@swift-chef-97535 Hey Thomas, are we good for tomorrow? Or do you prefer another day?
h
Hey, I wanted to take another look but unfortunately we were faced with an issue on our production system. Tomorrow I am completely booked with meetings. Thursday is the next possible date for a review on my end
Hey, I left a review yesterday. I did not yet look into the code of the saml provider itself
👀 2
🙏 1
e
Hello, just a quick message to let you know that we have taken into account your last review!(https://github.com/ory/kratos/pull/2653) Don't hesitate if you have any comments or feedback :)
❤️ 4