https://www.ory.sh/ logo
#talk-kratos
Title
# talk-kratos
h

high-optician-2097

10/28/2021, 5:29 PM
Hm, itโ€™s probably a bit incorrect. It definitely works when you use the
domain
setting in the config. So it can work, you just need to ensure to set the config. Maybe you could clarify that in the docs? That would be awesome!
b

blue-arm-79140

10/28/2021, 5:34 PM
Cheers thanks alot for such a quick response! The domain setting you are referring to would be
session.cookie.domain
right? And if thats the case if the value is something like
<http://somedomain.com|somedomain.com>
then all the subdomains under it should work?
h

high-optician-2097

10/28/2021, 5:36 PM
Yes, exactly ๐Ÿ™‚
b

blue-arm-79140

10/28/2021, 5:36 PM
Thank you!
h

high-optician-2097

10/28/2021, 5:36 PM
Would you be open to contribute this to the docs? If not itโ€™s also enough to open an issue (but PR would be preferred ๐Ÿ™‚ )
b

blue-arm-79140

10/28/2021, 5:38 PM
Sure I will check to see if i can make the PR, if not ill open it as an issue on the github repo!
h

high-optician-2097

10/28/2021, 5:40 PM
thank you ๐Ÿ™‚
b

blue-arm-79140

11/01/2021, 9:28 AM
Sorry to come back to this thread again but may I know what are the main reasons as to why the warning regarding usage of subdomain was there in the first place?
h

high-optician-2097

11/01/2021, 9:55 AM
because we did not have domain configs before
b

blue-arm-79140

11/01/2021, 10:33 AM
Ahh i see thanks. Does it make sense then for that warning to be removed? If so i can make a PR for the change to the docs?