https://www.ory.sh/ logo
Powered by
m

miniature-cartoon-25997

01/26/2022, 8:41 PM
Hey folks. I've been investigating ory/fosite and happened to notice that for fosite construct there is this 
FormPostHTMLTemplate
that sets the template for authorization response when the request has response_mode=form_post. I can see the potential of that being an option upon init that we can provide an optional template (probably via an opts method). But currently I don't think there is a way to do that. Is there any plan to do so? If not I'm happy to drop some code to support that. Appreciate some feedback and suggestions. 🙏
@User maybe you can help here? Thanks!
c

clean-hamburger-91078

01/28/2022, 8:20 AM
Idk, sorry. I'm not from Ory nor the contributor to fosite 😞
m

miniature-cartoon-25997

01/28/2022, 3:22 PM
ah cool thanks!
sorry for tagging but maybe @User or @User has an idea?
I think this would be beneficial since it allows dynamic template formatting and gives the control to hydra, which is a good improvement IMO
h

high-optician-2097

01/28/2022, 3:26 PM
hey, sounds like a good idea, feel free to submit a PR 🙂
🙏 1
m

miniature-cartoon-25997

01/28/2022, 3:26 PM
awesome, thanks @User
Test failed to the PR, but it looks like a failure when testing hydra. not sure how to address it.
@User Thanks for merging this! I see that this commit is labeled as v0.0.0. Do we want to keep it as-is or move to maybe v.0.42.1? I want to test it with my local change so a better tag might be helpful 🙏
m

magnificent-energy-493

02/03/2022, 7:49 PM
I think there will be a proper minor release for it soon. v.0.0.0. is "unreleased".
m

miniature-cartoon-25997

02/09/2022, 3:56 PM
Got it. Thank you @User!
h

high-optician-2097

02/09/2022, 3:57 PM
we released it! 🙂
m

miniature-cartoon-25997

02/09/2022, 4:00 PM
Yup saw it. Awesome thanks @User!
Powered by