is this a correct method