is this a correct approach