Hello team! We've tried to contribute, however our...
# talk-kratos
f
Hello team! We've tried to contribute, however our PR is failing on some code coverage. We have investigated, and we do not think that such a test case would make much sense. Is that a blocking factor for having the PR accepted? Another question is what can be expected of the timeline of having a review and making it into a release? We are 100% dependent on this feature to be able adopt the product. https://github.com/ory/kratos/pull/2765 Best regards Nichlas, Lunar Bank
m
Hello Nichlas, Thanks a ton for your contribution 🎉! I think the e2e CI is failing since you are contributing from a fork. Otherwise I don’t think the CI is a blocking factor. Please have some patience on the feature, generally we don’t give out timelines for open source releases to prevent maintainer burnout. Our “main” maintainer is also on holiday until next week. We will see to give you a review as soon as possible. We can give out timelines and prioritise features for our managed service if that is something you looked into, I can connect you with the appropriate people.
f
Hi Vincent. Okay, thanks. We will not do any further work until reviewed. I do understand that you cannot give a timeline. Can you tell a few lines or point me to somewhere, where the release pipeline is descripted? Is it monthly releases or how is it working? 🙂
m
Hey Nichlas, You can have a look at the CI here. Looking at the past releases, every other month or so is realistic. https://github.com/ory/kratos/releases I think there will be a release once this feature is implemented, and hopefully we can get your PR also in there. I will let the team know about your PR as well, I think its actually a nice feature that many user could profit from.
Ps: you can also post something next week in #contributors, that channel is dedicated to contributions & PR discussion.
f
I will, thank. you Vincent 🙂