https://www.ory.sh/ logo
Join Slack
Powered by
<@U04PDLR0P37> I'm trying to test the helm changes...
# contributors
m
@enough-yak-81379 I'm trying to test the helm changes for the test locally as there seems to be an issue. Is there an easy way to run this locally?
e
hi there, sure thing!
in the makefile we have some helpers for that: https://github.com/ory/k8s/blob/master/Makefile#L102
m
ok perfect
e
then to run the test locally simply run 
hacks/helm-test.sh ${HELM_CHART}
it looks like the dsn is not being correctly passed down to the command in the migration job 🤔
maybe we will need to add the 
"${DSN}
to the command string?
m
yeah I'm checking into that now. I think I've got the tests going locally.
👍 1
e
hey, i see the upgrade keeps failing, but installation passes
during upgrade we first install the chart from the release using the supplied values and then upgrade the chart to what is on your branch
it looks like this step passed correctly, then upgrade starts, migration goes first and passes, but the core deployment is crashing 🤔
i think this is the problem: 
W0514 14:34:13.430481    9031 warnings.go:70] spec.template.spec.containers[0].env[1].name: duplicate name "DSN"
during upgrade (upgrade from a release with the default behaviour to the sideloaded dsn) results in a duplication of the dsn value, and probably only the first (original) is taken into account then
because in the crashing pod we see
Copy code
DSN:                          <set to the key 'dsn' in secret 'kratos-1715697208'>                Optional: false
m
It's because there was a problem with the initial fix
The env vars shouldn't be duplicated
just checking on that.
you might be right about the upgrade - but I think there is still an issue as I get a duplicate when just generating the template.
e
as helm does a client side apply
m
I assume I can use helm-upgrade.sh to replicate?
e
yeah it does the whole install -> upgrade process
🙏 1
m
ok I figured it all out. Now I just have to make sure the original thing actually works and make it uniform across all of the charts. I'll re-request review when it's all ready.
6 Views
Open in Slack
PreviousNext
Powered by