We’re experiencing breaking changes with server co...
# ory-network
f
We’re experiencing breaking changes with server connecting to Ory. We’d been using Ory Go SDK 1.1.5 and as of a few hours ago it started failing with this error
Copy code
code is not a valid IdentityCredentialsType
that occurred here
Copy code
identity, err := s.oryClient.GetIdentity(ctx, id)
identityCredentials := identity.GetCredentials()  //  <--- This fails because data schema coming over the wire is different and doesn't deserialize
we eventually traced this to an update to Ory 1.2.x and are applying a hot fix to update out client libraries. Worrying to have external system break our user management workflows. Our expectation is that it would be a 2.x if there was something breaking, or at least some advance warning of a breaking change that we could prepare for. Was this an uncaught bug and/or is there a way to get communication in front of updates in the future?
h
Hey Chris, this is definitely a bad experience! Have you also tried updating to a newer 1.1.x version of the Go SDK? We fixed a bug 3 months back which contributed to this issue and believe that newer 1.1.x versions should have fixed that. We still think that this is not an acceptable behavior, and are trying to find ways to improve the auto-generated SDKs. If nothing else works, we will have to either write custom templates for the Go generator, or fix the upstraem templates of the Go SDK generator. In any case, a big sorry for this issue. Generally speaking, our REST APIs are always fully backwards compatible. Unfortunately, the Go SDK generators are written by the OpenAPI community, and sometimes they have issues like these. Not an excuse, just an explanation!
f
Hi, thanks for reply. Updating to v1.2.1 of the Go SDK fixed the issue. Good to understand there is an effort for backwards compatibility.
h
Have you also tried the latest 1.1.x version (1.1.51)? We tried reproducing the issue but had no success so far
f
I’ll go back and try to generate a repro for you.
👍 1
h
Hi, I just followed up on the investigation with the SDK issue. It appears that 1.1.51 is also working correctly. We fixed the problem about 3 months ago in the SDK so that unknown fields / values no longer cause panics or other issues. From here one out, stuff like this should not happen again! So in that case, you did not need to update to v1.2.x to resolve the issue. An update to a newer 1.1.x version was already sufficient!