Hey people!
The update identity admin endpoint is...
# ory-networkc
curved-fountain-46946
06/14/2023, 1:01 PMHey people!
The update identity admin endpoint is failing for us now, giving us 400's because we are sending it "invalid json". Why it's invalid?
unknown field: verifiable_addressess
steep-lamp-91158
06/14/2023, 1:04 PM
did it work some time already?
c
curved-fountain-46946
06/14/2023, 1:04 PMYeah, it broke kinda recently
s
steep-lamp-91158
06/14/2023, 1:05 PM
can you show the payload you are sending?
c
curved-fountain-46946
06/14/2023, 1:06 PMSure, let me dump you one
s
steep-lamp-91158
06/14/2023, 1:06 PM
I assume it is this endpoint right?
https://{project}.<http://projects.oryapis.com/admin/identities/{id}|projects.oryapis.com/admin/identities/{id}>h
high-optician-2097
06/14/2023, 1:06 PM
probably patch
high-optician-2097
06/14/2023, 1:07 PM
regression
s
steep-lamp-91158
06/14/2023, 1:07 PM
ah yeah...
c
curved-fountain-46946
06/14/2023, 1:08 PMYeah, so what we're doing is we're getting an identity, then calling updateIdentity on the sdk, with the same identity we fetched, right? And since the fetched identity has verifiable_addresses set, the updateIdentity call fails
s
steep-lamp-91158
06/14/2023, 1:09 PM
ok workaround would be to remove that field
c
curved-fountain-46946
06/14/2023, 1:09 PMWe could probably fix it on our end by deleting the fields that the updateIdentity endpoint doesen't like, but I think that feels too hacky
s
steep-lamp-91158
06/14/2023, 1:09 PM
cause it gets ignored anyway
c
curved-fountain-46946
06/14/2023, 1:09 PMLike, if we fetch an entity, change something without adding anything, and post that entity back, we shouldn't get the feedback that "the entity you posted is invalid"
curved-fountain-46946
06/14/2023, 1:10 PMI mean, we got it from your endpoint to begin with, right?
curved-fountain-46946
06/14/2023, 1:10 PMOr do you not agree?
s
steep-lamp-91158
06/14/2023, 1:11 PM
in an ideal rest world yes, but AFAIK the
verifiable_addressesc
curved-fountain-46946
06/14/2023, 1:11 PMSo we have to clean the data manually before sending it back to you? By design?
curved-fountain-46946
06/14/2023, 1:11 PMI mean sure, if that's the design, that's what we'll do
s
steep-lamp-91158
06/14/2023, 1:12 PM
no it should just be ignored, but there was a small bug https://github.com/ory/x/commit/39f02ce7ec7ce7502058a7b52c337a064706423e
c
curved-fountain-46946
06/14/2023, 1:13 PMOh, so it's already fixed
curved-fountain-46946
06/14/2023, 1:13 PMWhen will it be merged and deployed?
s
steep-lamp-91158
06/14/2023, 1:14 PM
the update identity body struct is not equal to the identity: https://github.com/ory/kratos/blob/95ad94d08efdbb369caecaa64cd0a30058c34ed3/identity/handler.go#L563-L595
c
curved-fountain-46946
06/14/2023, 1:15 PMAaaah
curved-fountain-46946
06/14/2023, 1:16 PMWell in that case it's on us
curved-fountain-46946
06/14/2023, 1:17 PMObviously, this never happened in Go because of type safety - in python, however, it's an entirely diffferent story
h
high-optician-2097
06/14/2023, 1:19 PM
thanks patrik
c
curved-fountain-46946
06/14/2023, 1:19 PMYeah, thanks dude, sorry about the bother!
s
steep-lamp-91158
06/14/2023, 1:32 PM
np, we'll probably release tomorrow to restore the old behavior
✅ 1
l
limited-photographer-61008
06/14/2023, 2:00 PMSomewhat related. I’m reading through the Kratos code to try and find the source of this bug, https://github.com/ory/kratos/issues/3187, but I haven’t been able to narrow it down due to lack of context. I think it may be in this function, though since the request is just sending the identity id and a json patch, it is unclear how the email address in the traits even has an effect on the behaviour. Maybe through the associations?
s
steep-lamp-91158
06/14/2023, 2:44 PM
I don't think that is related, but interesting bug 😅
c
curved-fountain-46946
06/14/2023, 2:48 PMYeah, this one hit us too once, we had to recreate like 300 identities 😛
curved-fountain-46946
06/14/2023, 2:48 PMWith normalized (lower-cased) email addresses
l
limited-photographer-61008
06/14/2023, 3:01 PMRelated in the sense that it involved updating identities and verifiable_addresses. But yeah, the source of the two issues is definitely not the same.
5 Views