are there anticipated changes to https://github.com/ory/kratos/blob/v0.5.1-alpha.1/selfservice/strategy/oidc/provider_discord.go#L81 since discord is rolling out new names? thinking

Name

will maybe need to change, since there's no longer going to be a discriminator.

good point, thanks for brining it up. I don’t see any notices on the discord docs, did they announce changes to the OIDC claims? If so, could you post a link to it?

Doesn't talk about OAuth2 specifically but talks about applications in general: https://support-dev.discord.com/hc/en-us/articles/13667755828631-Updating-Apps-to-Support-Unique-Usernames#h_01GYA87X9QZ19H2X6PJ3M35ZDH During the migration period, i.e. now, usernames still have a #0 appended, which will be removed after

I see, looks like they want everyone to move to an ID based system. Not entirely sure, we can do that without breaking anything, will need to investigate. Could either of you create an issue in ory/kratos so we can track this? Thank you!

Note that that #0 is just there temporarily and will be removed later

Sorry I missed your messages, I was only seeing Jonas's first message in this thread, the rest only showed up for me after I re-opened the slack app. I don't think discord would just yank a data field from the current API, it has to be removed in a new API version right?

it has to be removed in a new API version right?

I would hope so! And if there is a new API version we’re probably going to support it. But thanks again, for bringing this to our attention.

Y'all would be surprised :v) This username migration has been heavily criticized, with one point being that it'll inevitably break bots and applications that arent being developed anymore. I've also found this in the changelog, which while referring to the user object from the API, should probably apply to OAuth2 claims as well: https://discord.com/developers/docs/change-log#identifying-migrated-users It mentions that the discriminator field may be removed

thanks for picking this up while I was sleeping--do I understand correctly that there's no action for now, or do we need to create an issue related to this?

I don’t think anything is required right now. At least until discord is done with the name migration, (I’d say). Do let us know if you experience any issues with it. We’ll monitor the situation and announce any required changes.