Hi all, I created the following <PR> and the step ...
# contributors
d
Hi all, I created the following PR and the step format fails but Prettier locally does not find a format problem. Does anyone have any idea why?
m
Hey Jordan, thanks for your PR! We can also merge it with the format pipeline failing, its no blocker IMO - I would push a seperate format commit, takes 1 minute. Is https://github.com/ory/examples/pull/71 a replacement for https://github.com/ory/examples/pull/67 or an addition? Should I review yours first? In any case, planning to review either 71 or 67 tomorrow, am a bit out of the loop on this example, thanks for your patience & contribution 🙏
d
Hey Vincent, thanks for you reply I get it now. I'm used to working with Gitlab CI pipelines so I'm trying to figure out how it works on Github. This PR https://github.com/ory/examples/pull/71 is an addition to https://github.com/ory/examples/pull/67 because your PR does not use the latest code for the kratos selfservice UI project and therefore the design, fonts and icons were not good in your PR. If you have any questions, don't hesitate.
194 Views